Use the query vtable in query_feed plumbing#151853
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Feb 3, 2026
Merged
Use the query vtable in query_feed plumbing#151853rust-bors[bot] merged 1 commit intorust-lang:mainfrom
query_feed plumbing#151853rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
query_feedfunction needs to be able to do two important things with (erased) query values: hash them, and debug-print them.Both of those are things that the query's vtable already knows how to do. So by passing in a vtable to
query_feed, we can give it a nicer signature, avoid having to unerase values in the function itself, and clean up some caller-side code as well.